CommonServiceLocator Issue Tracker Rss Feed

Created Issue: Spelling Errors in Microsoft.Practices.ServiceLocation.Resources.resx [16054]

durbs182 — Wed, 20 Feb 2013 13:06:00 GMT

__ActivationExceptionMessage__

Activation error __occured__ while trying to get instance of type {0}, key "{1}"

__occured__ should be __occurred__

__ActivateAllExceptionMessage__

Activation error __occured__ while trying to get all instances of type {0}

__occured__ should be __occurred__

Commented Issue: Portable version to support all platforms [15106]

tillig — Mon, 03 Dec 2012 17:17:14 GMT

Posted as discussion by onovotny: http://commonservicelocator.codeplex.com/discussions/347703.
 
I wanted to propose using the new VS 11 Portable libraries to enable a single instance of the CommonServiceLocator to work with .NET 4, SL4+, WP7.1+, WinRT and XBox 360.
 
The only breaking change is that IServiceProvider has been removed from WinRT and so isn't available for portable libraries. From an API perspective, in my test build, I simply moved the single GetService method to the IServiceLocator interface instead.
 
Between using it as a Portable Library and the removal of IServiceProivder, the changes would warrant a version bump to 2.0 to prevent accidental conflicts. If you can get that built and put on to NuGet, it would enable you to have a single binary that all platforms can reference.
Comments: ** Comment from web user: tillig **

It appears this has been released for download but isn't in the official CommonServiceLocator NuGet package. Is there a plan to update the package and include the portable version?

Created Issue: Add NeutralResourcesLanguageAttribute to avoid PCL warning [15788]

ejball — Fri, 16 Nov 2012 20:34:28 GMT

As discussed below, the PCL assembly needs a NeutralResourcesLanguageAttribute.

http://commonservicelocator.codeplex.com/workitem/15106
http://commonservicelocator.codeplex.com/discussions/347703

Commented Issue: Portable version to support all platforms [15106]

onovotny — Sat, 06 Oct 2012 17:56:34 GMT

The new PCL version is missing the NeutralResourcesLanguageAttribute. That's generating a compiler warning:

Warning 1 The assembly "C:\Users\Public\Downloads\CodePlex\MVVMLight\GalaSoft.MvvmLight\Portable\packages\Portable.CommonServiceLocator.1.2\lib\portable-net4+sl4+wp7+win8\Microsoft.Practices.ServiceLocation.dll" does not have a NeutralResourcesLanguageAttribute on it. To be used in an app package, portable libraries must define a NeutralResourcesLanguageAttribute on their main assembly (ie, the one containing code, not a satellite assembly). C:\Users\Public\Downloads\CodePlex\MVVMLight\GalaSoft.MvvmLight\Portable\packages\Portable.CommonServiceLocator.1.2\lib\portable-net4+sl4+wp7+win8\Microsoft.Practices.ServiceLocation.dll GalaSoft.MvvmLight.Test.Portable.WinRT

Can you please add the attribute and re-release the PCL binary?

Thanks!

Commented Issue: Portable version to support all platforms [15106]

MichaelKetting — Fri, 24 Aug 2012 12:38:55 GMT

Posted as discussion by onovotny: http://commonservicelocator.codeplex.com/discussions/347703.

I wanted to propose using the new VS 11 Portable libraries to enable a single instance of the CommonServiceLocator to work with .NET 4, SL4+, WP7.1+, WinRT and XBox 360.

The only breaking change is that IServiceProvider has been removed from WinRT and so isn't available for portable libraries. From an API perspective, in my test build, I simply moved the single GetService method to the IServiceLocator interface instead.

Between using it as a Portable Library and the removal of IServiceProivder, the changes would warrant a version bump to 2.0 to prevent accidental conflicts. If you can get that built and put on to NuGet, it would enable you to have a single binary that all platforms can reference.
Comments: ** Comment from web user: MichaelKetting **

Removing IServiceProvider would also solve the conundrum of how to throw/not throw on GetService.
http://commonservicelocator.codeplex.com/discussions/389293

Regards, Michael

Commented Issue: ServiceLocator.Current throws NullReferenceException [9676]

abatishchev — Sun, 17 Jun 2012 11:51:56 GMT

When no IoC container is registered using ServiceLocator.SetLocatorProvider(ServiceLocatorProvider) the Current property will throw a NullReferenceException. Throwing a NullReferenceException is always a bad thing for a reusable framework such as CSL, or to quote the Framework Design Guidelines: "DO NOT allow publicly callable APIs to explicitly or implicitly throw NullReferenceException".

The Current property should check if the currentProvider delegate is null and if so, throw an InvalidOperationException with an expressive exception message, explaining what is wrong and what should be done to resolve this issue.
Comments: ** Comment from web user: abatishchev **

That's annoying and ridiculous that Current throws exception instead of returning null on initial check.

Commented Issue: FileLoadException in xaml designer [15215]

andyste1 — Wed, 23 May 2012 10:02:35 GMT

I have just created a new WPF project (VS2010) and added references to some assemblies required by the project, including Microsoft.Practices.ServiceLocation. Whenever I open a xaml file in the VS xaml designer, it displays the following exception:-

System.IO.FileLoadException
Could not load file or assembly 'Microsoft.Practices.ServiceLocation, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. Operation is not supported. (Exception from HRESULT: 0x80131515)
at System.Reflection.RuntimeAssembly._nLoad(AssemblyName fileName, String codeBase, Evidence assemblySecurity, RuntimeAssembly locationHint, StackCrawlMark& stackMark, Boolean throwOnFileNotFound, Boolean forIntrospection, Boolean suppressSecurityChecks)
at System.Reflection.RuntimeAssembly.nLoad(AssemblyName fileName, String codeBase, Evidence assemblySecurity, RuntimeAssembly locationHint, StackCrawlMark& stackMark, Boolean throwOnFileNotFound, Boolean forIntrospection, Boolean suppressSecurityChecks)
at System.Reflection.RuntimeAssembly.InternalLoadAssemblyName(AssemblyName assemblyRef, Evidence assemblySecurity, StackCrawlMark& stackMark, Boolean forIntrospection, Boolean suppressSecurityChecks)
at System.Reflection.Assembly.Load(AssemblyName assemblyRef)
at MS.Internal.Package.VSIsolationProviderService.RemoteReferenceProxy.VsReflectionResolver.GetRuntimeAssembly(Assembly reflectionAssembly)
at Microsoft.Windows.Design.Metadata.ReflectionMetadataContext.CachingReflectionResolver.GetRuntimeAssembly(Assembly reflectionAssembly)
at Microsoft.Windows.Design.Metadata.ReflectionMetadataContext.Microsoft.Windows.Design.Metadata.IReflectionResolver.GetRuntimeAssembly(Assembly reflectionAssembly)
at MS.Internal.Metadata.ClrAssembly.GetRuntimeMetadata(Object reflectionMetadata)
at Microsoft.Windows.Design.Metadata.AttributeTableContainer.<MergeAttributesIterator>d__c.MoveNext()
at Microsoft.Windows.Design.Metadata.AttributeTableContainer.GetAttributes(Assembly assembly, Type attributeType, Func`2 reflectionMapper)
at MS.Internal.Metadata.ClrAssembly.GetAttributes(ITypeMetadata attributeType)
at MS.Internal.Design.Metadata.Xaml.XamlAssembly.get_XmlNamespaceCompatibilityMappings()
at Microsoft.Windows.Design.Metadata.Xaml.XamlExtensionImplementations.GetXmlNamespaceCompatibilityMappings(IAssemblyMetadata sourceAssembly)
at Microsoft.Windows.Design.Metadata.Xaml.XamlExtensions.GetXmlNamespaceCompatibilityMappings(IAssemblyMetadata source)
at MS.Internal.Design.Metadata.ReflectionProjectNode.BuildSubsumption()
at MS.Internal.Design.Metadata.ReflectionProjectNode.SubsumingNamespace(Identifier identifier)
at MS.Internal.Design.Markup.XmlElement.BuildScope(PrefixScope parentScope, IParseContext context)
at MS.Internal.Design.Markup.XmlElement.ConvertToXaml(XamlElement parent, PrefixScope parentScope, IParseContext context, IMarkupSourceProvider provider, Boolean visitCodeModel)
at MS.Internal.Design.DocumentModel.DocumentTrees.Markup.XamlSourceDocument.FullParse(Boolean convertToXamlWithErrors)
at MS.Internal.Design.DocumentModel.DocumentTrees.Markup.XamlSourceDocument.get_RootItem()
at Microsoft.Windows.Design.DocumentModel.Trees.ModifiableDocumentTree.get_ModifiableRootItem()
at Microsoft.Windows.Design.DocumentModel.MarkupDocumentManagerBase.get_LoadState()
at MS.Internal.Host.PersistenceSubsystem.Load()
at MS.Internal.Host.Designer.Load()
at MS.Internal.Designer.VSDesigner.Load()
at MS.Internal.Designer.VSIsolatedDesigner.VSIsolatedView.Load()
at MS.Internal.Designer.VSIsolatedDesigner.VSIsolatedDesignerFactory.Load(IsolatedView view)
at MS.Internal.Host.Isolation.IsolatedDesigner.BootstrapProxy.LoadDesigner(IsolatedDesignerFactory factory, IsolatedView view)
at MS.Internal.Host.Isolation.IsolatedDesigner.BootstrapProxy.LoadDesigner(IsolatedDesignerFactory factory, IsolatedView view)
at MS.Internal.Host.Isolation.IsolatedDesigner.Load()
at MS.Internal.Designer.DesignerPane.LoadDesignerView(Boolean isReload)

System.NotSupportedException
An attempt was made to load an assembly from a network location which would have caused the assembly to be sandboxed in previous versions of the .NET Framework. This release of the .NET Framework does not enable CAS policy by default, so this load may be dangerous. If this load is not intended to sandbox the assembly, please enable the loadFromRemoteSources switch. See http://go.microsoft.com/fwlink/?LinkId=155569 for more information.

--------------------------------------------------

The last paragraph seems to be a red herring as I am not loading any projects or assemblies from network shares. The entire solution and all dependent assemblies (including Service Locator) are on my local C: drive.

If I remove the project reference to Microsoft.Practices.ServiceLocation, then I can open the xaml files normally. Note also that I have not actually made use of the service locator anywhere in my code, I have merely referenced the DLL in the project. Nor have I made any changes to the xaml files - I get the exception as soon as I open a newly added xaml.

Any ideas? Thanks in advance
Andy
Comments: ** Comment from web user: andyste1 **

Ok, it's always the way - you find a solution just after you've posted the problem.

For anyone else with this issue, it's due to Windows 7 knowing that the DLL was downloaded from the web (even though it was inside a zip at the time). To fix it, right-click the DLL, choose Properties, then click the "Unblock" button. Voila!

Created Issue: FileLoadException in xaml designer [15215]

andyste1 — Wed, 23 May 2012 09:40:41 GMT

Created Issue: Portable version to support all platforms [15106]

dot_NET_Junkie — Sat, 28 Apr 2012 14:04:43 GMT

Commented Issue: ServiceLocator.Current throws NullReferenceException [9676]

thoughtcriminal — Fri, 14 Oct 2011 11:32:48 GMT

There has been a patch (5879) submitted jkitaaic on May 2 2010 which is being evaluated.
How long does it take to evaluate a patch at Microsoft?
Can you show us that you care about your .NET developer community and take care of this issue?

Commented Issue: ServiceLocator.Current throws NullReferenceException [9676]

thoughtcriminal — Fri, 14 Oct 2011 11:26:59 GMT

Can you please fix it as soon as possible? It's the highest voted issue and a change to return null would will not brake compatibility with the current version at all.

Commented Issue: ServiceLocator.Current throws NullReferenceException [9676]

thoughtcriminal — Fri, 14 Oct 2011 11:23:23 GMT

It should return null, throwing exceptions is a bad idea in this case.
Catching NullReferenceException is not reliable (not to mention perf).

Created Issue: Provide a new method GetInstanceType<>(String key) to return the 'MappedToType' associated with a specified key. [14336]

DGDev — Sat, 08 Oct 2011 01:48:38 GMT

Provide a new method GetInstanceType<>(String key) to return the 'MappedToType' associated with a specified key.

Brief:
In unity, the names: "RegisteredType" and "MappedToType" refer to properties for each registration within the IUnityContainer.Registrations collection.
The names are synonymous with the common: Register<FromType, ToType>
I would imagine all DI containers to have similar functionality.

Scenario:
I have multiple registrations sharing the same "RegisteredType", each with a specific key. If I only have the "RegisteredType" and a key, I would like to get the MappedToType Type object.

Use Case:
In the dictionary below, the key (Type) would be MappedToType objects.
Dictionary<Type, RegisteredType> _Store;

I want to determine if _Store contains the type associated with the specific RegisteredType / service location key. Hence a method like GetInstanceType<From>(String key) would be of value. I don't necessarily want to flat out go and resolve a new instance if I already have it in _Store.

Currently, there is no was to do this without having the service locator / provider resolve an instance.

Commented Issue: No Support for IsRegistered (or HasMapping) [14016]

dot_NET_Junkie — Mon, 01 Aug 2011 19:36:32 GMT

It would be a really handy addition to be able to request if the container has a registration for for a particular situation. The specific need I have at the moment is that I want to be able to ask for a registration by name; if no specific registration exists for that name then I want to use the default, nameless registration. In this case it's all about using IoC to provide testability; I want to register a default container for an object that performs access to the database and then override this during testing with specific classes that fake the data access results I need for each test.

I have created a sample class that shows the situation I am trying to support through the service locator; I can do this with Unity but can't do it in an agnostic way through CommonServiceLocator
Comments: ** Comment from web user: dot_NET_Junkie **

I suspect you are taking the wrong approach, but the issue tracker is the wrong place to discuss this. The best place to discuss this is on Stackoverflow. Describe your situation (type of application) with some code examples and say that you can't accomplish this with the CSL and ask if you are taking the right approach. Tag your question with ".net c# ioc-container common-service-locator dependency-injection" and you will get one or more high quality answers very soon.

Created Issue: No Support for IsRegistered (or HasMapping) [14016]

rockyrocks — Mon, 01 Aug 2011 14:30:25 GMT

Created Issue: Defect in ServiceLocatorImplBase() [13589]

CodeInChaos — Wed, 25 May 2011 09:43:37 GMT

The implementation of ServiceLocatorImplBase<TService>() is flawed.
The contract states:
[quote]
A call to:

IEnumerable<TService> IServiceLocator.GetAllInstances<TService>()

Must be exactly equivalent to a call to:

IEnumerable<object> IServiceLocator.GetAllInstances(typeof(TService))

with the exception that the objects returned by the enumerator are already cast to type TService.
[/quote]

The implementation is:
[code]
public abstract class ServiceLocatorImplBase : IServiceLocator
{
...

public virtual IEnumerable<TService> GetAllInstances<TService>()
{
foreach (object item in GetAllInstances(typeof(TService)))
{
yield return (TService)item;
}
}

...
}
[/code]

The problem with this implementation is that it `GetAllInstances(type)` is only called when enumerating. This means if it throws an exception or its expected behavior changes over time it will violate the contract. The correct solution is to not use a `yield return` based implementation.
If you're targetting .net 3.5 `return GetAllInstances(typeof(TService)).Cast<TService>();` should do the job. If you're targetting .net 2.0 you'll need to implement it yourself.

Commented Issue: ServiceLocator.Current throws NullReferenceException [9676]

turtur — Thu, 31 Mar 2011 08:03:59 GMT

Maybe add a property HasCurrent. Maybe throw InvalidOperationException when trying to fetch Current when no locator has been set.

Created Issue: Null reference handling [12807]

RenEvo — Sun, 09 Jan 2011 00:37:15 GMT

While testing the ServiceLocator.Current.GetInstance method, I passed a null to verify the libraries design correctness (we use Microsoft Basic Design Guidelines Rules, and try to test our external libraries for them).

I ran into this exception when calling:

ServiceLocator.Current.GetInstance(null);

Stack Trace:

at Microsoft.Practices.ServiceLocation.ServiceLocatorImplBase.FormatActivationExceptionMessage(Exception actualException, Type serviceType, String key) in c:\Home\Chris\Projects\CommonServiceLocator\main\Microsoft.Practices.ServiceLocation\ServiceLocatorImplBase.cs:line 149
at Microsoft.Practices.ServiceLocation.ServiceLocatorImplBase.GetInstance(Type serviceType, String key) in c:\Home\Chris\Projects\CommonServiceLocator\main\Microsoft.Practices.ServiceLocation\ServiceLocatorImplBase.cs:line 53
at Microsoft.Practices.ServiceLocation.ServiceLocatorImplBase.GetInstance(Type serviceType) in c:\Home\Chris\Projects\CommonServiceLocator\main\Microsoft.Practices.ServiceLocation\ServiceLocatorImplBase.cs:line 34
at DiscoveryPrototype.ClientApp.Program.Main(String[] args) in D:\Projects\DiscoveryPrototype\DiscoveryPrototype.ClientApp\Program.cs:line 19
at System.AppDomain._nExecuteAssembly(RuntimeAssembly assembly, String[] args)
at System.AppDomain.ExecuteAssembly(String assemblyFile, Evidence assemblySecurity, String[] args)
at Microsoft.VisualStudio.HostingProcess.HostProc.RunUsersAssembly()
at System.Threading.ThreadHelper.ThreadStart_Context(Object state)

The ServiceLocatorImplBase should really have null checks in all methods for all used parameters. Although it is an edge case, you could ask for an instance of an object passing in the type that came from the return of a method that DOES return null, and then the exception is not caught at the proper place.

Commented Issue: Provide a pure .NET 4 signed release [12616]

styx31 — Thu, 02 Dec 2010 14:35:41 GMT

Because the source does not contain the key to sign the library, we are unable to build a pure .NET 4 signed release.

It's a critical requirement when we have existing signed .NET 2 code based on the current release and we want to migrate to .NET 4.

Basically we can use the .NET 2 version, but our assembly will be flagged using both .NET 2 mscorlib & .NET 4 mscorlib.

1) If we use the current release, our signed assembly will be flagged referencing both .NET 2 & .NET 4 (visible using reflector)
2) If we compile the DLL by ourself, we have to drop the strong name (and are unable to sign further assemblies) or sign the assembly by ourself (and so breaking all references)
Comments: ** Comment from web user: styx31 **

Similar as WP7 support in #10607

Created Issue: Provide a pure .NET 4 signed release [12616]

styx31 — Thu, 02 Dec 2010 14:34:54 GMT